feat(hook): Deliver events to integrations - #607
Draft
prathshenoy wants to merge 1 commit into
Draft
Conversation
1 task
prathshenoy
force-pushed
the
prath.shenoy/hook-event-contract
branch
from
August 17, 2026 16:54
b5394eb to
837e0d8
Compare
prathshenoy
force-pushed
the
prath.shenoy/hook-dispatch
branch
from
August 17, 2026 16:56
a09dcab to
b6aef89
Compare
prathshenoy
marked this pull request as ready for review
August 17, 2026 16:56
prathshenoy
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
August 17, 2026 16:56
prathshenoy
force-pushed
the
prath.shenoy/hook-event-contract
branch
from
August 18, 2026 00:27
837e0d8 to
b5394eb
Compare
prathshenoy
force-pushed
the
prath.shenoy/hook-dispatch
branch
from
August 18, 2026 00:27
b6aef89 to
a09dcab
Compare
1 task
Collaborator
|
🛑 Automatic stack rebase aborted — diff mismatch The rebase of Please rebase manually and verify the changes are correct. |
mnoah1
reviewed
Aug 19, 2026
behinddwalls
pushed a commit
to behinddwalls/submitqueue
that referenced
this pull request
Aug 19, 2026
## Summary **What**: - Define the shared event format every domain publishes for fire-and-forget lifecycle notifications, carrying origin, type, timing, a staleness marker, and open per-event detail. - Derive an event's identity from the transition it describes, so replaying a transition produces the same identity and duplicate deliveries collapse. **Why**: - Enable integrations to react to pipeline milestones without adding call sites that can stall or fail a merge. - Establish one schema and one identity rule before any producer ships, so a consumer spanning several domains needs only one reader. ## Test Plan - [x] Add unit tests. ## Revert Plan - Revert this PR. No topic is registered and no message of this shape exists on any queue. ## Issues - [CODEM-416](https://linear.app/uber/issue/CODEM-416/hooks-integration-downstream-notificaiton) ## Stack 1. @ uber#606 1. uber#607 1. uber#608
| ) | ||
|
|
||
| // Hook performs a side effect in response to a lifecycle event. | ||
| type Hook interface { |
Collaborator
There was a problem hiding this comment.
my general question here is why is it an extension vs a plain consumer who gets hooks events from wire and implements consumer controller? why it needs to be an interface?
behinddwalls
requested changes
Aug 19, 2026
| // on. Dropping an observability row costs a gap in a read model; dropping a | ||
| // merge-failure comment costs a support ticket, and nothing else in the system | ||
| // will notice it is missing. | ||
| type DLQController struct { |
Collaborator
There was a problem hiding this comment.
do we need to provide DLQ Hook extension as well? so we do think in most cases, there is nothing to really reconcile, but say for example, I want to close PR when merge is done and for whatever reason that fails..should we have ability to handle those from retries and DLQ? just a thought, we don't need to support as such
prathshenoy
force-pushed
the
prath.shenoy/hook-dispatch
branch
from
August 20, 2026 20:54
a09dcab to
56a21ac
Compare
An error occurred while trying to automatically change base from
prath.shenoy/hook-event-contract
to
main
August 20, 2026 20:58
An error occurred while trying to automatically change base from
prath.shenoy/hook-event-contract
to
main
August 20, 2026 20:58
An error occurred while trying to automatically change base from
prath.shenoy/hook-event-contract
to
main
August 20, 2026 20:58
An error occurred while trying to automatically change base from
prath.shenoy/hook-event-contract
to
main
August 20, 2026 20:58
prathshenoy
force-pushed
the
prath.shenoy/hook-dispatch
branch
from
August 20, 2026 20:59
56a21ac to
63b4e01
Compare
prathshenoy
changed the base branch from
prath.shenoy/hook-event-contract
to
main
August 20, 2026 21:36
prathshenoy
marked this pull request as draft
August 20, 2026 22:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What:
Why:
Test Plan
Revert Plan
Issues